Several updates to Uno #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using HADOOP_HOME in place of HADOOP_PREFIX * Using HADOOP_LOG_DIR instead of YARN_LOG_DIR
ctubbsii
approved these changes
Sep 4, 2018
bin/impl/fetch.sh
Outdated
| function download_other() { | ||
| url_prefix=$1 | ||
| tarball=$2 | ||
| expected_hash=$3 |
There was a problem hiding this comment.
These variables should be defined as local variables, as in:
local url_prefix; url_prefix=$1Always a good idea to run shellcheck also.
* Falls back to Apache archive if tarball is not found on mirror * Allow fetch of only Hadoop or ZooKeeper
mikewalch
force-pushed
the
uno-update
branch
from
c300fe3 to
2126f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.