Fixes #166 Made it easier to get hashes #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
approved these changes
Mar 12, 2018
|
I was just curious... Why didn't you make one file with all the hashes in it? |
ctubbsii
reviewed
Mar 12, 2018
There was a problem hiding this comment.
Should use fgrep (or grep -F), not grep, since versions contain dots, and these patterns could easily be found in long strings of hashes if the dots are matched to "any character". Should also use a different delimiter, like :, instead of space, so you can include that in the grep pattern, because you can't use ^ with -F.
|
I created #172 to address both of your concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.