[FLINK-39135] [flink-gs-fs-hadoop] Set proper precondition to ensure GCS operations are retryable#27689
Open
jonchase wants to merge 2 commits intoapache:release-1.20from
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ensures that the operations become idempotent or atomic, allowing the GCS client to safely retry the 503 errors. Thus client can actually perform the retry in such conditions.
Original retry logic was added in #24753.
It was then added to the compose operation in #27101. This PR cherry picks that PR into the 1.20 release branch.
Brief change log
Verifying this change
This change is already covered by existing tests, such as GSRecoverableWriterTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation