Skip to content

[FLINK-39026][runtime] Remove misleading TODO about getPartitionedState overhead #27517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nateab wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-39026][runtime] Remove misleading TODO about getPartitionedState overhead #27517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,6 @@ public void publishQueryableStateIfEnabled(
}
}

/**
* TODO: NOTE: This method does a lot of work caching / retrieving states just to update the
* namespace. This method should be removed for the sake of namespaces being lazily fetched from
* the keyed state backend, or being set on the state directly.
*
* @see KeyedStateBackend
*/
@SuppressWarnings("unchecked")
@Override
public <N, S extends State> S getPartitionedState(
Expand Down
4 changes: 0 additions & 4 deletions flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ <N, S extends State, T> S getOrCreateKeyedState(
/**
* Creates or retrieves a partitioned state backed by this state backend.
*
* <p>TODO: NOTE: This method does a lot of work caching / retrieving states just to update the
* namespace. This method should be removed for the sake of namespaces being lazily fetched from
* the keyed state backend, or being set on the state directly.
*
* @param stateDescriptor The identifier for the state. This contains name and can create a
* default state value.
* @param <N> The type of the namespace.
Expand Down
7 changes: 0 additions & 7 deletions ...me/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,13 +428,6 @@ protected <S extends State, N> S getPartitionedState(
TypeSerializer<N> namespaceSerializer,
StateDescriptor<S, ?> stateDescriptor)
throws Exception {

/*
TODO: NOTE: This method does a lot of work caching / retrieving states just to update the namespace.
This method should be removed for the sake of namespaces being lazily fetched from the keyed
state backend, or being set on the state directly.
*/

if (keyedStateBackend != null) {
return keyedStateBackend.getPartitionedState(
namespace, namespaceSerializer, stateDescriptor);
Expand Down