Skip to content

Conversation

@lurongjiang
Copy link

What is the purpose of the change

developers receive unhelpful error messages when parameters are null.

Brief change log

Replace checkNotNull(clusterRestEndpointAddress, clusterRestEndpointAddress) with checkNotNull(clusterRestEndpointAddress, "clusterRestEndpointAddress") to ensure the exception message clearly identifies the null parameter.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 20, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@lurongjiang lurongjiang deleted the lrj branch November 21, 2025 10:59
@lurongjiang lurongjiang restored the lrj branch November 21, 2025 11:26
@lurongjiang
Copy link
Author

I misunderstood the merge process. I thought that getting an approval meant I should close it, but I now understand that maintainers handle the final merge.
I've restored the branch. It contains the exact same changes as before: fixing the NPE in StandaloneHaServices and adding the corresponding unit test.
I'm truly sorry for the extra work this may have caused. Please let me know if there's anything else I need to do.

@lurongjiang lurongjiang reopened this Nov 21, 2025
@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants