Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37090][e2e] Add adaptive broadcast join to e2e tpc-ds tests. #25954

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

SinBex
Copy link
Contributor

@SinBex SinBex commented Jan 10, 2025

What is the purpose of the change

Add adaptive broadcast join to e2e tpc-ds tests.

In this case, we will set the AdaptiveBroadcastJoinStrategy to RUNTIME_ONLY, significantly increasing the likelihood of triggering adaptive broadcast join.

Brief change log

  • Add adaptive broadcast join to e2e tpc-ds tests.

Verifying this change

This change is already covered by existing tests, such as test_tpcds.sh.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 10, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@SinBex
Copy link
Contributor Author

SinBex commented Jan 11, 2025

@flinkbot run azure

1 similar comment
@SinBex
Copy link
Contributor Author

SinBex commented Jan 12, 2025

@flinkbot run azure

@SinBex SinBex force-pushed the jira-37090 branch 2 times, most recently from c67f958 to 4f81268 Compare January 16, 2025 02:18
Copy link
Contributor

@JunRuiLee JunRuiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunRuiLee JunRuiLee merged commit 65db14d into apache:master Jan 16, 2025
JunRuiLee added a commit to JunRuiLee/flink that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants