-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36759][sql-gateway] Add REST API to deploy script in application mode #25730
Conversation
c1d4fb3
to
14941a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsk119 Thanks for your contribution, I left some comments.
...-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java
Show resolved
Hide resolved
.../flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/DeployScriptITCase.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-gateway/src/test/resources/sql_gateway_rest_api_v4.snapshot
Outdated
Show resolved
Hide resolved
...link-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/SqlGatewayService.java
Show resolved
Hide resolved
...eway-api/src/test/java/org/apache/flink/table/gateway/api/utils/MockedSqlGatewayService.java
Outdated
Show resolved
Hide resolved
new SessionMessageParameters(sessionHandle), | ||
new DeployScriptRequestBody( | ||
script, | ||
null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s recommended to pass a test ExecutionConfig here instead of null to verify whether executionConfig takes effect correctly.
...-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsk119 Thanks for the update, LGTM. only left one minor comment
...-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java
Outdated
Show resolved
Hide resolved
...-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
The failed test is because REST endpoint doesn't start in 30 seconds. In my private pipline, e2e test passes. |
What is the purpose of the change
Add REST API to deploy script into application cluster.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation