Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36759][sql-gateway] Add REST API to deploy script in application mode #25730

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

fsk119
Copy link
Member

@fsk119 fsk119 commented Dec 3, 2024

What is the purpose of the change

Add REST API to deploy script into application cluster.

Brief change log

  • Add deployScript method in service to deploy cluster.
  • Add REST API to deploy script.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 3, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fsk119 fsk119 force-pushed the rest-api branch 6 times, most recently from c1d4fb3 to 14941a2 Compare December 11, 2024 08:06
Copy link
Contributor

@hackergin hackergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsk119 Thanks for your contribution, I left some comments.

new SessionMessageParameters(sessionHandle),
new DeployScriptRequestBody(
script,
null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s recommended to pass a test ExecutionConfig here instead of null to verify whether executionConfig takes effect correctly.

Copy link
Contributor

@hackergin hackergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsk119 Thanks for the update, LGTM. only left one minor comment

@fsk119
Copy link
Member Author

fsk119 commented Jan 4, 2025

@flinkbot run azure

@fsk119
Copy link
Member Author

fsk119 commented Jan 4, 2025

The failed test is because REST endpoint doesn't start in 30 seconds. In my private pipline, e2e test passes.

https://dev.azure.com/1059623455/Flink/_build/results?buildId=652&view=logs&s=ae4f8708-9994-57d3-c2d7-b892156e7812&j=d63a5fc4-24ea-51df-9ade-fa4330af161c

@fsk119 fsk119 merged commit 3084561 into apache:master Jan 4, 2025
@fsk119 fsk119 deleted the rest-api branch January 4, 2025 15:17
xaniasd pushed a commit to xaniasd/flink that referenced this pull request Jan 13, 2025
Au-Miner pushed a commit to Au-Miner/flink that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants