Skip to content

Conversation

@slankka
Copy link
Contributor

@slankka slankka commented Oct 23, 2024

What is the purpose of the change

Using HiveCatalog will cause another hive program lost the hive-site.xml from HiveConf

This change will set HiveConf.hiveSiteLocation back.

Brief change log

Visit JIRA ticket to for details.

Verifying this change

(Please pick either of the following options)

This change is already covered by existing tests, such as (please describe tests).

org.apache.flink.table.catalog.hive.HiveCatalogTest#testCreateHiveConf

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 23, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@tomncooper
Copy link
Contributor

Looks like the CI on this failed due to the old Wikipedia tests that have now been removed.

@slankka can you rebase your PR and re-run the CI?

@slankka
Copy link
Contributor Author

slankka commented Jan 20, 2025

@tomncooper rebased and ci report SUCCESS

@slankka
Copy link
Contributor Author

slankka commented Feb 20, 2025

closed in favor of apache/flink-connector-hive#32

@slankka slankka closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants