[FLINK-35579] update frocksdb version to v8.10.0 by mayuehappy · Pull Request #25253 · apache/flink

mayuehappy · 2024-08-26T03:26:34Z

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2024-08-26T03:32:00Z

CI report:

32f492e UNKNOWN
f38435a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run azure re-run the last Azure build

mayuehappy · 2024-08-26T06:24:08Z

@flinkbot run azure

Zakelly · 2024-08-26T09:50:21Z

Is the CI failure related with compilation or release of the frocksdb?

mayuehappy · 2024-08-26T12:19:12Z

Is the CI failure related with compilation or release of the frocksdb?

@Zakelly The compilation looks fine
There are two main reasons why CI has failed
The error message for one is open db

Caused by: org.rocksdb.RocksDBException: `/dev/null' exists but is not a directory
Aug 26 06:55:21 	at org.rocksdb.RocksDB.open(Native Method) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.rocksdb.RocksDB.open(RocksDB.java:315) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.apache.flink.contrib.streaming.state.RocksDBOperationUtils.openDB(RocksDBOperationUtils.java:77) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.apache.flink.contrib.streaming.state.restore.RocksDBHandle.loadDb(RocksDBHandle.java:138) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.apache.flink.contrib.streaming.state.restore.RocksDBHandle.openDB(RocksDBHandle.java:114) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.apache.flink.contrib.streaming.state.restore.RocksDBNoneRestoreOperation.restore(RocksDBNoneRestoreOperation.java:62) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	at org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackendBuilder.build(RocksDBKeyedStateBackendBuilder.java:376) ~[flink-dist-2.0-SNAPSHOT.jar:2.0-SNAPSHOT]
Aug 26 06:55:21 	... 20 more

And another is UT RocksDBResourceContainerTest.testGetColumnFamilyOptionsWithPartitionedIndex

Aug 26 07:39:29 07:39:29.881 [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.029 s <<< FAILURE! -- in org.apache.flink.contrib.streaming.state.RocksDBResourceContainerTest
Aug 26 07:39:29 07:39:29.881 [ERROR] org.apache.flink.contrib.streaming.state.RocksDBResourceContainerTest.testGetColumnFamilyOptionsWithPartitionedIndex -- Time elapsed: 0.008 s <<< FAILURE!
Aug 26 07:39:29 java.lang.AssertionError: 
Aug 26 07:39:29 
Aug 26 07:39:29 Expected: not <org.rocksdb.BloomFilter@4024001f>
Aug 26 07:39:29      but: was <org.rocksdb.BloomFilter@4024001f>
Aug 26 07:39:29 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
Aug 26 07:39:29 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
Aug 26 07:39:29 	at org.apache.flink.contrib.streaming.state.RocksDBResourceContainerTest.testGetColumnFamilyOptionsWithPartitionedIndex(RocksDBResourceContainerTest.java:320)
Aug 26 07:39:29 	at java.lang.reflect.Method.invoke(Method.java:498)

I'll try to reproduce it on my local machine and figure out how to fix it

mayuehappy · 2024-08-26T12:42:36Z

RocksDBResourceContainerTest.testGetColumnFamilyOptionsWithPartitionedIndex failed because RocksDB-V8.10.0 Overrided the equals() of org.rocksdb.BloomFilter .In RocksDBResourceContainerTest although comparing different objects, this will still return true so the UT to fail.

mayuehappy · 2024-08-27T08:52:07Z

Caused by: org.rocksdb.RocksDBException: `/dev/null' exists but is not a directory

This is because when run e2e test, the directory of rocksdb log will be specified as /dev/null by default. But in Rocksdb-v8.10 will call s = env->CreateDirIfMissing(options.db_log_dir); This will lead the creation of Logger to fail.

mayuehappy · 2024-08-28T03:20:18Z

@flinkbot run azure

mayuehappy · 2024-08-28T08:17:23Z

@Zakelly the CI can pass now , I've two minor changes , please take a look

Zakelly · 2024-08-28T11:18:03Z

  # this would make e2e tests' artifacts containing too many log files.
  # As RocksDB's log would not help much in e2e tests, move the location back to its own folder.
-  set_config_key "state.backend.rocksdb.log.dir" "/dev/null"
+  set_config_key "state.backend.rocksdb.log.dir" "/tmp"


I'm a little worried that this would lead to many files in "/tmp" and disk space run out in CI machine. Is there any way we disable the log?

I think we can set state.backend.rocksdb.log.level to HEADER_LEVEL, in that case RocksDB Log file will be very small

But it still creates the log file, right? So /tmp will still accumulate trash log files. How about setting log level to header and keeping them in Flink's log directory?

But it still creates the log file, right? So /tmp will still accumulate trash log files. How about setting log level to header and keeping them in Flink's log directory?

yeah, that's what I mean !

@Zakelly I've updated the PR and the CI has passed now, can you take a look

Zakelly

LGTM, thanks for the effort!

[FLINK-35579] update frocksdb version to v8.10.0

df3cd8e

flinkbot added the component=Runtime/StateBackends label Aug 26, 2024

fix ci

30bcad5

fix ci

e94c1bb

mayuehappy added 2 commits August 27, 2024 11:55

fix ci

f135a93

fix ci

32f492e

relocation rocksdb log to /tmp

2b39c27

mayuehappy force-pushed the update-frocksdb-jni branch from f7b337d to 2b39c27 Compare August 27, 2024 12:03

relocation rocksdb log to /tmp

6126f87

Zakelly reviewed Aug 28, 2024

View reviewed changes

set rocksdb log level

f38435a

Zakelly approved these changes Aug 29, 2024

View reviewed changes

Zakelly merged commit 576ec2b into apache:master Aug 29, 2024

Conversation

mayuehappy commented Aug 26, 2024

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

Uh oh!

flinkbot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI report:

Uh oh!

mayuehappy commented Aug 26, 2024

Uh oh!

Zakelly commented Aug 26, 2024

Uh oh!

mayuehappy commented Aug 26, 2024

Uh oh!

mayuehappy commented Aug 26, 2024

Uh oh!

mayuehappy commented Aug 27, 2024

Uh oh!

mayuehappy commented Aug 28, 2024

Uh oh!

mayuehappy commented Aug 28, 2024

Uh oh!

Zakelly Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

mayuehappy Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

Zakelly Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

mayuehappy Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

mayuehappy Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Zakelly left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

flinkbot commented Aug 26, 2024 •

edited

Loading