[FLINK-35526] Use more up to date jq docker image for Flink e2e tests #24892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I am good with either option though. |
dawidwys
approved these changes
Jun 5, 2024
|
Thanks for the review. I actually like your proposal a lot. Will change it. |
|
First iteration of this PR was green: https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=60071 |
robobario
reviewed
Jun 5, 2024
| @@ -150,7 +150,7 @@ function s3_get_number_of_lines_by_prefix() { | |||
|
|
|||
| # find all files that have the given prefix | |||
| parts=$(aws_cli s3api list-objects --bucket "$IT_CASE_S3_BUCKET" --prefix "$1" | | |||
| docker run -i --rm stedolan/jq -r '[.Contents[].Key] | join(" ")') | |||
| docker run -i --rm ghcr.io/jqlang/jq -r '[.Contents[].Key] | join(" ")') | |||
There was a problem hiding this comment.
Would it be worth adding in the version tag instead of using latest? Thinking about test reproducibility.
There was a problem hiding this comment.
Very good point, thank you!
rmetzger
added a commit
that referenced
this pull request
Jun 6, 2024
rmetzger
added a commit
that referenced
this pull request
Jun 6, 2024
hlteoh37
pushed a commit
that referenced
this pull request
Jun 6, 2024
superdiaodiao
pushed a commit
to superdiaodiao/flink
that referenced
this pull request
Jul 4, 2024
snuyanzin
pushed a commit
to snuyanzin/flink
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI logs contain this warning: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=60060&view=logs&j=af184cdd-c6d8-5084-0b69-7e9c67b35f7a&t=0f3adb59-eefa-51c6-2858-3654d9e0749d&l=3828