Skip to content

[FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector #23920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector #23920

wants to merge 1 commit into from

Conversation

MartijnVisser
Copy link
Contributor

What is the purpose of the change

  • Resolve FLINK-33793 java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage

Brief change log

  • Make sure that Guava is bundled for GCS connector

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser MartijnVisser mentioned this pull request Dec 13, 2023
Closed
snuyanzin
snuyanzin reviewed Dec 14, 2023
View reviewed changes
flink-filesystems/flink-gs-fs-hadoop/src/main/resources/META-INF/NOTICE Outdated
@@ -32,6 +32,7 @@ This project bundles the following dependencies under the Apache Software Licens
- com.google.flogger:flogger-system-backend:0.7.1
- com.google.flogger:flogger:0.7.1
- com.google.flogger:google-extensions:0.7.1
- com.google.guava:guava:31.1-jre
Copy link
Contributor

@snuyanzin snuyanzin Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to have guava 31.1 here if current google-cloud-storage depends on 32.1.2 ?

snuyanzin
snuyanzin reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM
however I still have one question about version for guava

@JingGe
Copy link
Contributor

JingGe commented Dec 14, 2023

please see my comment in the original PR: #23489 (comment)

@MartijnVisser MartijnVisser changed the base branch from master to release-1.18 December 15, 2023 13:43
@MartijnVisser @singhravidutt
[FLINK-33603][Filesystem] Bundle Guava for GCS connector
7c60900 
This includes removing Guava from `flink-fs-hadoop-shaded`

Co-authored-by: Ravi Dutt Singh <singhravidutt@gmail.com>
@MartijnVisser MartijnVisser changed the title [FLINK-33603][Filesystem] Bundle Guava for GCS connector [FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector Dec 15, 2023
@MartijnVisser
Copy link
Contributor Author

Superseded by https://issues.apache.org/jira/browse/FLINK-33704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snuyanzin snuyanzin snuyanzin left review comments

Assignees
No one assigned
Labels
component=Connectors/FileSystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartijnVisser @flinkbot @JingGe @snuyanzin @singhravidutt