[FLINK-32418][formats-protobuf] Fix ClassNotFoundException when using protobuf in SQL-Client #23032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
This pull request changes protobuf format to always use the classloader which is passed on creation for the
DynamicTableFactory.Context
instead of using the thread local classloader as proposed in FLINK-32418. This is needed to load generated protobuf classes when using the protobuf format in SQL-Client.Change log
DynamicTableFactory.Context
is stored in aPbFormatContext
which is then passed further down the componentsPbFormatUtils.getDescriptor
has an additional parameter where the classloader from the PbFormatContaxt has to be passed to resolve generated Protobuf classes correctly.Verifying this change
This change is already covered by existing tests, such as
SimpleProtoToRowTest
.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation