Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-28171 enable add appProtocol via the configuration #22936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sigalite
Copy link

@sigalite sigalite commented Jul 3, 2023

What is the purpose of the change

enable the job manager and task manager communicate in a Kubernetes cluster with Istio and mTLS enabled.

Brief change log

Add the “appProtocol” in the task manager and job manager configuration, verify they are not overridden by the default definition in the decorators

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, - -ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@sigalite
Copy link
Author

sigalite commented Jul 3, 2023

@wangyang0918, @MartijnVisser please review. thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 3, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants