Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-31928][build] Upgrade okhttp3 to 4.11.0 #22498

Closed
wants to merge 0 commits into from
Closed

[FLINK-31928][build] Upgrade okhttp3 to 4.11.0 #22498

wants to merge 0 commits into from

Conversation

cy2008
Copy link

@cy2008 cy2008 commented Apr 28, 2023 •
edited
Loading

What is the purpose of the change

This pull allow flink-kubernetes work correctly in k8s with ipv6 stack which described in https://issues.apache.org/jira/projects/FLINK/issues/FLINK-31928

Brief change log

Upgrade okhttp3 to version 4.11.0 and add required dependencies in flink-kubernetes.

Verifying this change

This change could be verified by the testNodePortService in Fabric8FlinkKubeClientTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 28, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

healchow
healchow reviewed May 1, 2023
View reviewed changes
flink-kubernetes/pom.xml Outdated
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, why introduce this package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve kotlin version conflict used by okhttp3 4.x .

@cy2008 cy2008 requested a review from healchow May 4, 2023 09:37
healchow
healchow approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cy2008 cy2008 force-pushed the master branch 7 times, most recently from cf002e1 to d6a76b2 Compare May 5, 2023 07:32
@cy2008
Copy link
Author

cy2008 commented May 5, 2023

@flinkbot run azure

@cy2008
Copy link
Author

cy2008 commented May 5, 2023

@flinkbot run azure

@cy2008 cy2008 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@healchow healchow healchow approved these changes

Assignees
No one assigned
Labels
component=Deployment/Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cy2008 @flinkbot @healchow