Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27482][code] Updated config.sh #21631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anksinghal
Copy link

@anksinghal anksinghal commented Jan 9, 2023

This changes will fix issue pointed out in FLINK-27482.

I have seen that when Flink is installed on D drive while Cygwin is installed on C drive mangled path will convert d:/ to d;c:/ which is wrong. It always wants Flink and Cgywin to be installed on same drive. So fixing the same issue.

What is the purpose of the change

This changes will fix issue pointed out in FLINK-27482.

I have seen that when Flink is installed on D drive while Cygwin is installed on C drive mangled path will convert d:/ to d;c:/ which is wrong. It always wants Flink and Cgywin to be installed on same drive. So fixing the same issue.

Brief change log

Passing unmangled path for bin directory which gets mangled in runBashJavaUtilsCmd.
(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)
code cleanup
This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

This changes will fix issue pointed out in FLINK-27482.

I have seen that when Flink is installed on D drive while Cygwin is installed on C drive mangled path will convert d:/<path to flink bin> to d;c:/<path to flink bin> which is wrong. It always wants Flink and Cgywin to be installed on same drive. So fixing the same issue.
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 9, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants