Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30036][kubernetes] force delete pod when the k8s node is under NotReady state #21329

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Grypse
Copy link
Contributor

@Grypse Grypse commented Nov 16, 2022

What is the purpose of the change

This pull request check whether the node where the pod resides is in the NotReady state. If yes, delete the pod forcibly.

Brief change log

  • Add KubernetesNode resource defination
  • Before deleting a pod, check whether the status of the node where the pod resides is normal. If no, delete the pod forcibly.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change added tests and can be verified as follows:

  • Added Unit test to test the node NotReady status get is right.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@Grypse Grypse changed the title [FLINK-30036] force delete pod when the k8s node is under NotReady st… [FLINK-30036][kubernetes] force delete pod when the k8s node is under NotReady st… Nov 16, 2022
@Grypse Grypse changed the title [FLINK-30036][kubernetes] force delete pod when the k8s node is under NotReady st… [FLINK-30036][kubernetes] force delete pod when the k8s node is under NotReady state Nov 16, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 16, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Grypse
Copy link
Contributor Author

Grypse commented Nov 16, 2022

@wangyang0918 Please help me review this.

@Grypse
Copy link
Contributor Author

Grypse commented Nov 16, 2022

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants