Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][FLINK-29055][k8s] add K8S options for excluding the buildin decorators #20668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bzhaoopenstack
Copy link
Contributor

Introduce 2 options for excluding the buildin decorators for jobmanager
and taskmanager.

What is the purpose of the change

Provide a way to exclude the existing decorators.

Brief change log

  • Introduce 2 options for jobmanager and taskmanager k8s options.
  • Maintain a outside Class for generate the said stepDecorators to operate k8s resources.

Verifying this change

  • UTs had been finished.
  • Insert several full path classes of existing Decorators to exclude, and verify on the real env whether the associated resources won't be created.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 23, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Introduce 2 options for excluding the buildin decorators for jobmanager
and taskmanager.
@bzhaoopenstack
Copy link
Contributor Author

@flinkbot run azure

2 similar comments
@bzhaoopenstack
Copy link
Contributor Author

@flinkbot run azure

@bzhaoopenstack
Copy link
Contributor Author

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants