-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28825][k8s] Add K8S pod scheduler into Kubernetes options #20467
base: master
Are you sure you want to change the base?
[FLINK-28825][k8s] Add K8S pod scheduler into Kubernetes options #20467
Conversation
57f78e5
to
ac63567
Compare
636032b
to
941e29c
Compare
Hi, thanks for review. And apologize for my late reply. Yeah, that would be another easy way to set scheduler name via template. But we would also provide a way for users when they submit job via CLI, also for supporting plugin Step Decorators(K8S Custom Schedulers), there would be many cases that users setting the schedulers more frequently or upper-level controller management platform. So I think that would be valuable for introducing setting the said scheduler field via Configuration option. ;-) |
cbacd2a
to
f12aefd
Compare
docs/layouts/shortcodes/generated/kubernetes_config_configuration.html
Outdated
Show resolved
Hide resolved
docs/layouts/shortcodes/generated/kubernetes_config_configuration.html
Outdated
Show resolved
Hide resolved
docs/layouts/shortcodes/generated/kubernetes_config_configuration.html
Outdated
Show resolved
Hide resolved
...ernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
Outdated
Show resolved
Hide resolved
We introduce 3 options for supporting specify the K8S pod scheduler name. They are: kubernetes.jobmanager.scheduler-name kubernetes.taskmanager.scheduler-name kubernetes.scheduler-name The first two of them can be specified by users to control the k8s pod scheduler they used for jobmanager and taskmanager. The last one is the fallback one, the first two options will overwrite it.
f12aefd
to
1d88556
Compare
I have a question. |
Hi, @bzhaoopenstack , what is the status of this PR? Are you still working on it? Thanks. |
I will handle this PR as @bzhaoopenstack successor 。 And I also commit a PR as replenish 。 bzhaoopenstack#5 I wish more friends can give some advices。 Thanks. I wish we can merge these PR, which can help flink work on k8s better。 |
We introduce 3 options for supporting specify the K8S pod scheduler
name.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
This change is introduced by FLIP-250 for supporting specify pod scheduler name by users. This PR introduces 3 options for it.
Brief change log
New options are:
kubernetes.jobmanager.scheduler-name
kubernetes.taskmanager.scheduler-name
kubernetes.scheduler-name
The first two of them can be specified by users to control the k8s pod
scheduler they used for jobmanager and taskmanager. The last one is the
fallback one, the first two options will overwrite it.
Verifying this change
Kubernetes deployment support 3 new options now. Can check the backend pods scheduler name whether is the same with the specified one.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation