Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23595][formats / json] JSON format support deserialize non-numeric numbe fields #16813

Closed
wants to merge 2 commits into from

Conversation

loyispa
Copy link
Contributor

@loyispa loyispa commented Aug 13, 2021

What is the purpose of the change

This pull request makes json format support deserialize non-numeric number fields (default: throw an exception). For example, NaNInfinity or -Infinity.

FLINK-23595

Brief change log

Add new JsonFormatOptions: allow-non-numeric-numbers

Involved implemention:

  • json
  • maxwell-json
  • canal-json
  • debezium-json

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

no

This change is already covered by existing tests.

  • Add test in JsonFormatFactoryTest to cover parse options cases.
  • Add test in CanalJsonFormatFactoryTest to cover parse options cases.
  • Add test in DebeziumJsonFormatFactoryTest to cover parse options cases.
  • Add test in MaxwellJsonFormatFactoryTest to cover parse options cases.
  • Add test in JsonRowDataSerDeSchemaTest to cover deserialize non-numeric number cases.
  • Add test in CanalJsonSerDeSchemaTest to cover deserialize non-numeric number cases.
  • Add test in DebeziumJsonSerDeSchemaTest to cover deserialize non-numeric number cases.
  • Add test in MaxwellJsonSerDerTest to cover deserialize non-numeric number cases.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e2e7163 (Fri Aug 13 10:40:53 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 13, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@loyispa
Copy link
Contributor Author

loyispa commented Aug 17, 2021

@wuchong hi, do you have time to take a look ?

@loyispa loyispa marked this pull request as draft August 18, 2021 11:19
@loyispa loyispa marked this pull request as ready for review August 18, 2021 11:20
@loyispa
Copy link
Contributor Author

loyispa commented Aug 22, 2021

@Airblader Sorry to interrupt you, do you have time to finish this review ?

@loyispa loyispa closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants