-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23595][formats / json] JSON format support deserialize non-numeric numbe fields #16813
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit e2e7163 (Fri Aug 13 10:40:53 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonFormatOptions.java
Outdated
Show resolved
Hide resolved
...ats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonFormatFactory.java
Outdated
Show resolved
Hide resolved
…ns.ALLOW_NON_NUMERIC_NUMBERS
@wuchong hi, do you have time to take a look ? |
@Airblader Sorry to interrupt you, do you have time to finish this review ? |
What is the purpose of the change
This pull request makes json format support deserialize non-numeric number fields (default: throw an exception). For example, NaN、 Infinity or -Infinity.
FLINK-23595
Brief change log
Add new JsonFormatOptions: allow-non-numeric-numbers
Involved implemention:
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
no
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes)Documentation