Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22594][Kubernetes]Add handler to catch pod oomKilled message a… #16208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aitozi
Copy link
Contributor

@Aitozi Aitozi commented Jun 19, 2021

…nd report to resource manager metric

What is the purpose of the change

As described in issue, this pr is meant to report oom killed to metric in k8s mode.

Brief change log

  • Add PodOOMHandler to handle pod modify message

Verifying this change

This change added tests and can be verified by PodOOMHandlerTest

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 19, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit cf7500f (Sat Aug 28 12:20:59 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Aitozi
Copy link
Contributor Author

Aitozi commented Jun 19, 2021

@flinkbot run travis

@Aitozi
Copy link
Contributor Author

Aitozi commented Jun 19, 2021

@flinkbot run travis

@Aitozi
Copy link
Contributor Author

Aitozi commented Jun 22, 2021

cc @wangyang0918 could you help have a look on this pr ?

@Aitozi
Copy link
Contributor Author

Aitozi commented Sep 3, 2021

ping @wangyang0918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants