Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20219][coordination] Shutdown cluster externally should only clean up the HA data if all the jobs have finished #16121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wangyang0918
Copy link
Contributor

@wangyang0918 wangyang0918 commented Jun 9, 2021

What is the purpose of the change

FLINK-20695 has supported to clean up the HA related data(ZNode/ConfigMaps, as well as HA storage) once the job reached to the global terminal state. This PR now is focused on graceful shutdown cluster once received an external signal.

What is the graceful shutdown behavior?

  • If Flink cluster still has running jobs, then the HA related data will be retained.
  • If no jobs running, all the ZNodes/ConfigMaps and the HA storage will be cleaned up.

Brief change log

  • Shutdown cluster externally should only clean up the HA data if all the jobs have finished

Verifying this change

  • Add corresponding unit tests
    • testShutDownClusterWithRunningJobsShouldCompleteShutDownFutureExceptionally
    • testShutDownFutureCompleteExceptionallyShouldNotCleanUpHAData
    • testShutDownFutureCompleteWithNotAllJobsFinishedExceptionShouldNotCleanUpHAData
    • testShutDownFutureCompleteNormallyShouldCleanUpHAData

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…lean up the HA data if all the jobs have finished
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 9, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 132ae02 (Sat Aug 28 12:15:47 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 9, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wangyang0918
Copy link
Contributor Author

cc @tillrohrmann maybe you would like to have a look on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants