Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21108][rest-client] Add basic & digest auth support to rest client #15365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunxiaoguang
Copy link
Contributor

Signed-off-by: Xiaoguang Sun sunxiaoguang@zhihu.com

What is the purpose of the change

Implement Basic & Digest Auth scheme in rest-client so Flink rest-server can be protected behind a proxy with corresponding authentication enabled.

Brief change log

  • Restart request and resend request again with corresponding authorization responses on receiving authentication challenge.
  • Abstract different authentication scheme and implemented two of the most widely used authentication schemes which are Basic and Digest
  • Add a special exception type RestartableException to Flink runtime concurrent package so that a task that can be restarted immediately can be handled differently in FututeUtils.java
  • Add two new config options to rest client to specify username and password

Verifying this change

This change added tests and can be verified as follows:

  • TODO

Does this pull request potentially affect one of the following parts:

NA

Documentation

  • Flink rest client can be verified against a secured proxy sitting in front of real Job Manager and makes Job Manager available to users have valid credential only.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3441a04 (Thu Mar 25 05:47:29 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@sunxiaoguang
Copy link
Contributor Author

I'm working on unit tests recently, comments on design and implementation about this feature is welcome. Thanks

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 25, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants