-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-35550][runtime] Adds new component RescaleManager that handles…
… the rescaling logic to improve code testability and extensibility Rescaling is a state-specific functionality. Moving all the logic into Executing state allows us to align the resource controlling in Executing state and WaitingForResources state in a future effort.
- Loading branch information
Showing
10 changed files
with
971 additions
and
351 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
167 changes: 167 additions & 0 deletions
167
...time/src/main/java/org/apache/flink/runtime/scheduler/adaptive/DefaultRescaleManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.scheduler.adaptive; | ||
|
|
||
| import org.apache.flink.annotation.VisibleForTesting; | ||
| import org.apache.flink.util.Preconditions; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.time.Duration; | ||
| import java.time.Instant; | ||
| import java.time.temporal.Temporal; | ||
| import java.util.function.Supplier; | ||
|
|
||
| /** | ||
| * {@code DefaultRescaleManager} manages triggering the next rescaling based on when the previous | ||
| * rescale operation happened and the available resources. It handles the event based on the | ||
| * following phases (in that order): | ||
| * | ||
| * <ol> | ||
| * <li>Cooldown phase: No rescaling takes place (its upper threshold is defined by {@code | ||
| * scalingIntervalMin}. | ||
| * <li>Soft-rescaling phase: Rescaling is triggered if the desired amount of resources is | ||
| * available. | ||
| * <li>Hard-rescaling phase: Rescaling is triggered if a sufficient amount of resources is | ||
| * available (its lower threshold is defined by (@code scalingIntervalMax}). | ||
| * </ol> | ||
| * | ||
| * @see Executing | ||
| */ | ||
| public class DefaultRescaleManager implements RescaleManager { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(DefaultRescaleManager.class); | ||
|
|
||
| private final Temporal initializationTime; | ||
| private final Supplier<Temporal> clock; | ||
|
|
||
| @VisibleForTesting final Duration scalingIntervalMin; | ||
| @VisibleForTesting @Nullable final Duration scalingIntervalMax; | ||
|
|
||
| private final RescaleManager.Context rescaleContext; | ||
|
|
||
| private boolean rescaleScheduled = false; | ||
|
|
||
| DefaultRescaleManager( | ||
| Temporal initializationTime, | ||
| RescaleManager.Context rescaleContext, | ||
| Duration scalingIntervalMin, | ||
| @Nullable Duration scalingIntervalMax) { | ||
| this( | ||
| initializationTime, | ||
| Instant::now, | ||
| rescaleContext, | ||
| scalingIntervalMin, | ||
| scalingIntervalMax); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| DefaultRescaleManager( | ||
| Temporal initializationTime, | ||
| Supplier<Temporal> clock, | ||
| RescaleManager.Context rescaleContext, | ||
| Duration scalingIntervalMin, | ||
| @Nullable Duration scalingIntervalMax) { | ||
| this.initializationTime = initializationTime; | ||
| this.clock = clock; | ||
|
|
||
| Preconditions.checkArgument( | ||
| scalingIntervalMax == null || scalingIntervalMin.compareTo(scalingIntervalMax) <= 0, | ||
| "scalingIntervalMax should at least match or be longer than scalingIntervalMin."); | ||
| this.scalingIntervalMin = scalingIntervalMin; | ||
| this.scalingIntervalMax = scalingIntervalMax; | ||
|
|
||
| this.rescaleContext = rescaleContext; | ||
| } | ||
|
|
||
| @Override | ||
| public void onChange() { | ||
| if (timeSinceLastRescale().compareTo(scalingIntervalMin) > 0) { | ||
| maybeRescale(); | ||
| } else if (!rescaleScheduled) { | ||
| rescaleScheduled = true; | ||
| rescaleContext.scheduleOperation(this::maybeRescale, scalingIntervalMin); | ||
| } | ||
| } | ||
|
|
||
| private Duration timeSinceLastRescale() { | ||
| return Duration.between(this.initializationTime, clock.get()); | ||
| } | ||
|
|
||
| private void maybeRescale() { | ||
| rescaleScheduled = false; | ||
| if (rescaleContext.hasDesiredResources()) { | ||
| LOG.info("Desired parallelism for job was reached: Rescaling will be triggered."); | ||
| rescaleContext.rescale(); | ||
| } else if (scalingIntervalMax != null) { | ||
| LOG.info( | ||
| "The longer the pipeline runs, the more the (small) resource gain is worth the restarting time. " | ||
| + "Last resource added does not meet the configured minimal parallelism change. Forced rescaling will be triggered after {} if the resource is still there.", | ||
| scalingIntervalMax); | ||
|
|
||
| // reasoning for inconsistent scheduling: | ||
| // https://lists.apache.org/thread/m2w2xzfjpxlw63j0k7tfxfgs0rshhwwr | ||
| if (timeSinceLastRescale().compareTo(scalingIntervalMax) > 0) { | ||
| rescaleWithSufficientResources(); | ||
| } else { | ||
| rescaleContext.scheduleOperation( | ||
| this::rescaleWithSufficientResources, scalingIntervalMax); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void rescaleWithSufficientResources() { | ||
| if (rescaleContext.hasSufficientResources()) { | ||
| LOG.info( | ||
| "Resources for desired job parallelism couldn't be collected after {}: Rescaling will be enforced.", | ||
| scalingIntervalMax); | ||
| rescaleContext.rescale(); | ||
| } | ||
| } | ||
|
|
||
| public static class Factory implements RescaleManager.Factory { | ||
|
|
||
| private final Duration scalingIntervalMin; | ||
| @Nullable private final Duration scalingIntervalMax; | ||
|
|
||
| /** | ||
| * Creates a {@code Factory} instance based on the {@link AdaptiveScheduler}'s {@code | ||
| * Settings} for rescaling. | ||
| */ | ||
| public static Factory fromSettings(AdaptiveScheduler.Settings settings) { | ||
| // it's not ideal that we use a AdaptiveScheduler internal class here. We might want to | ||
| // change that as part of a more general alignment of the rescaling configuration. | ||
| return new Factory(settings.getScalingIntervalMin(), settings.getScalingIntervalMax()); | ||
| } | ||
|
|
||
| private Factory(Duration scalingIntervalMin, @Nullable Duration scalingIntervalMax) { | ||
| this.scalingIntervalMin = scalingIntervalMin; | ||
| this.scalingIntervalMax = scalingIntervalMax; | ||
| } | ||
|
|
||
| @Override | ||
| public DefaultRescaleManager create(Context rescaleContext, Instant lastRescale) { | ||
| return new DefaultRescaleManager( | ||
| lastRescale, rescaleContext, scalingIntervalMin, scalingIntervalMax); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.