[FLINK-37578] Fix distributed schema registry exposes bad internal state accidentally #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, @yuxiqian. This pr looks good to me. |
Member
Author
|
Thanks for @lvyanquan's suggestion, traced in FLINK-37704. Perhaps more test cases could be added based on changes in #3965. |
lvyanquan
approved these changes
Apr 21, 2025
leonardBang
approved these changes
Apr 21, 2025
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @yuxiqian for the contribution, LGTM
linjianchang
pushed a commit
to linjianchang/flink-cdc
that referenced
this pull request
May 16, 2025
…d internal state accidentally This closes apache#3972 Co-authored-by: linjc13 <linjc13@chinatelecom.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-37578 and #3858.
There's a subtle sequential bug in both
SchemaCoordinators after a schema evolve coordination process finishes. Coordinator may finish operators' blocking state first before restoring internal state properly, which may accidentally expose unwanted internal states or freeze the entire pipeline job.@linjianchang's optimization in #3858 is actually correct, however it increases the chance of this glitch. Baked the original commit into this PR to test if it works well.