Skip to content

Conversation

@lvyanquan
Copy link
Contributor

@lvyanquan lvyanquan commented Jul 23, 2024

Add e2e test for PaimonDataSink.
This can be merged after #3818.

Coauthor with @yuxiqian

@lvyanquan
Copy link
Contributor Author

@yuxiqian Can you help to review this?

Copy link
Member

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work, I left some minor comments.

@github-actions github-actions bot removed the runtime label Jul 24, 2024
Copy link
Member

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work!

@yuxiqian
Copy link
Member

Seems CI is failing since 17ff659 doesn't generate test jar by default, which is required by Paimon E2e tests. Some changes like

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-jar-plugin</artifactId>
                <executions>
                    <execution>
                        <id>test-jar</id>
                        <goals>
                            <goal>test-jar</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

might be necessary.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 28, 2024
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Oct 28, 2024
@yuxiqian
Copy link
Member

@leonardBang Could you please reopen this?

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvyanquan and @yuxiqian for the co-work, LGTM

Copy link
Member

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work, I left some minor concerns about some changes in PipelineTestEnvironment, not sure if it's relevant to failing CI workflow.

@lvyanquan
Copy link
Contributor Author

Close this and trace in #3818 as this pr rely on #3818 to fix some bugs and #3818 also need to verify by e2e.

@lvyanquan lvyanquan closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants