[cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source #3445
+1,540
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengJie1053
changed the title
ChengJie1053
changed the title
|
Is there anyone who can help review this? |
Making a test merge to test the change in the wild
Master sqlserver
Master temp
AZ-000 - latest changes to data types
DE-145 - fixing Data type errors
Putting back the original checks that were temporarily removed during debugging.
|
@ChengJie1053 - I have opened a pull request to your master branch, as well as to apache master branch with a list of fixes and changes to the code your proposed - my pull request to apache is #3507 and my pull to your master is ChengJie1053#1 |
Updating to latest apache master
Syncing up with apache.
zakhalex
approved these changes
Aug 19, 2024
zakhalex
approved these changes
Aug 20, 2024
|
@ChengJie1053 - do you have the privilege to approve the workflows? |
I'm sorry. I don't have that clearance |
|
@ChengJie1053 Add some ITCases to help verify the correctness of the code will be better. |
Okay, thank you. I'll add test cases later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink cdc pipeline support sqlserver source
