Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rumtime] Hotfix in BinaryRecordDataSerializer with code refractor #2845

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[Rumtime] Hotfix in BinaryRecordDataSerializer with code refractor #2845

merged 1 commit into from
Dec 13, 2023

Conversation

xuzifu666
Copy link
Contributor

minor code refractor in BinaryRecordDataSerializer

@xuzifu666 xuzifu666 changed the title [Rumtime] hotfix in BinaryRecordDataSerializer code refractor [Rumtime] Hotfix in BinaryRecordDataSerializer with code refractor Dec 10, 2023
joyCurry30
joyCurry30 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@joyCurry30 joyCurry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! LGTM.

@xuzifu666
Copy link
Contributor Author

Thanks for the patch! LGTM.

Thanks for the patch! LGTM.

cc @joyCurry30 CI error seems not related to the changed code

leonardBang
leonardBang approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzifu666 for the contribution, LGTM

@leonardBang leonardBang merged commit e6bb8e9 into apache:master Dec 13, 2023
14 of 17 checks passed
@leonardBang leonardBang added this to the V3.1.0 milestone Dec 13, 2023
@gong gong mentioned this pull request Dec 14, 2023
Merged
lvyanquan pushed a commit that referenced this pull request Jan 18, 2024
@xuzifu666 @lvyanquan
[hotfix][cdc-rumtime][minor] Clean up useless code in BinaryRecordDat…
e6be824 
…aSerializer (#2845)

Co-authored-by: xuyu <11161569@vivo.com>
(cherry picked from commit e6bb8e9)
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
@xuzifu666 @joyCurry30
[hotfix][cdc-rumtime][minor] Clean up useless code in BinaryRecordDat…
b54b1b8 
…aSerializer (apache#2845)

Co-authored-by: xuyu <11161569@vivo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

@joyCurry30 joyCurry30 Awaiting requested review from joyCurry30

Assignees

@xuzifu666 xuzifu666

Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuzifu666 @leonardBang @joyCurry30