Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MongoDB CDC] Fix “pollAwaitTimeMillis” does not take effect #1994 #1995

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

liangyaohui97
Copy link
Contributor

No description provided.

@Jiabao-Sun Jiabao-Sun self-requested a review March 15, 2023 03:56
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liangyaohui97 for this contribution.
I left few comments.

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liangyaohui97 for the great work!
It LGTM in general. I made some changes about updating next update time because the heartbeat may also cost some time, using current time + time interval may be more accurate.

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI seems failed.

@Jiabao-Sun Jiabao-Sun merged commit a93db47 into apache:master Mar 24, 2023
@Jiabao-Sun
Copy link
Contributor

Jiabao-Sun commented Mar 24, 2023

The use case of CI failure has nothing to do with this PR.
Merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants