Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle] oracle table source Add missing parameters #1720

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

fuyun2024
Copy link
Contributor

oracle table source Add missing parameters

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fuyun2024 for the fix, Could you also add the configoptions in the connector document?

@fuyun2024
Copy link
Contributor Author

@leonardBang OK

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fuyun2024 for the update, LGTM

@leonardBang leonardBang merged commit c9bb718 into apache:release-2.3 Nov 9, 2022
@leonardBang
Copy link
Contributor

@fuyun2024 Could also open a PR for master branch?

fuyun2024 added a commit to fuyun2024/flink-cdc-connectors that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants