Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdc-base] Fix OffsetFactory is not initialized when restored from checkpoint #1657

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[cdc-base] Fix OffsetFactory is not initialized when restored from checkpoint #1657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .../src/main/java/com/ververica/cdc/connectors/base/source/assigner/HybridSplitAssigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class HybridSplitAssigner implements SplitAssigner {

private final SnapshotSplitAssigner snapshotSplitAssigner;

private OffsetFactory offsetFactory;
private final OffsetFactory offsetFactory;

public HybridSplitAssigner(
SourceConfig sourceConfig,
Expand All @@ -69,8 +69,8 @@ public HybridSplitAssigner(
dialect,
offsetFactory),
false,
sourceConfig.getSplitMetaGroupSize());
this.offsetFactory = offsetFactory;
sourceConfig.getSplitMetaGroupSize(),
offsetFactory);
}

public HybridSplitAssigner(
Expand All @@ -87,16 +87,19 @@ public HybridSplitAssigner(
dialect,
offsetFactory),
checkpoint.isStreamSplitAssigned(),
sourceConfig.getSplitMetaGroupSize());
sourceConfig.getSplitMetaGroupSize(),
offsetFactory);
}

private HybridSplitAssigner(
SnapshotSplitAssigner snapshotSplitAssigner,
boolean isStreamSplitAssigned,
int splitMetaGroupSize) {
int splitMetaGroupSize,
OffsetFactory offsetFactory) {
this.snapshotSplitAssigner = snapshotSplitAssigner;
this.isStreamSplitAssigned = isStreamSplitAssigned;
this.splitMetaGroupSize = splitMetaGroupSize;
this.offsetFactory = offsetFactory;
}

@Override
Expand Down