-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add report an issue #480
Add report an issue #480
Conversation
Waiting for issue actions/setup-node#1112 to rerun the CI rather than pinning the npm version lower. |
"pretest:e2e": "rm -rf ./test/e2e/chromeData/*", | ||
"posttest:e2e": "rm -rf ./test/e2e/chromeData/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to clean before and after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added because when a test fails playwright starts a server for the results that needs an interrupt signal to stop. That interrupt signal prevents the post command from cleaning up.
But on second thought, I'll just create an explicit script to cleanup that runs regardless of the main scripts completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out, you can't run a script after a SIGINT because of how npm handles SIGINT. So I'm leaving in the pre script.
><br /> | ||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ol' <br/>
to serve as padding instead of proper styles ;). Will let it slide for now.
@Jyyjy Tests now pass. Once you address issues, feel free to merge. |
This resolves #478 with the following changes
Example issue log:
{
"pageUrl": "https://www.openstreetmap.org/#map=19/40.46362/-79.93668&layers=D",
"pageTitle": "OpenStreetMap",
"pageReferrer": "",
"browser": {
"browser": "chrome",
"version": "126.0.0"
},
"clientTime": 1721321016597,
"scrnRes": {
"width": 487,
"height": 857
},
"logType": "custom",
"userAction": true,
"details": {},
"userId": "pluginUser",
"toolVersion": "2.4.0",
"toolName": "useralePlugin",
"useraleVersion": "2.4.0",
"sessionId": "session_1721103156601",
"httpSessionId": "e9ef871810b812bbafdfc232b5fd13a9",
"browserSessionId": "9047683c125414150c97c20753fe97a5",
"issueType": "Bug",
"issueDescription": "A detailed description of the issue.",
"type": "issue"
}