Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute logging example #332

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

Jyyjy
Copy link
Contributor

@Jyyjy Jyyjy commented Jan 4, 2023

This is an example solution to the discussion on issue #266.

@poorejc
Copy link
Contributor

poorejc commented Jan 21, 2023

This is great, I'm going to take a deeper read and test this week @Jyyjy!

Thinking that organization of examples is getting away from this. I'll raise on dev for thoughts on how to better organize our examples.

@poorejc poorejc self-requested a review January 21, 2023 05:24
@poorejc poorejc self-assigned this Jan 21, 2023
@poorejc poorejc added the Documentation Instructional Material and Reference label Jan 21, 2023
@Jyyjy
Copy link
Contributor Author

Jyyjy commented Jan 25, 2023

This is great, I'm going to take a deeper read and test this week @Jyyjy!

Thinking that organization of examples is getting away from this. I'll raise on dev for thoughts on how to better organize our examples.

I was planning on adding more examples after this one (e.g. mutation observer), so I just joined the flagon dev mailing list to join the discussion.

@asfgit asfgit merged commit 8336f4e into apache:test Jan 29, 2023
@poorejc
Copy link
Contributor

poorejc commented Jan 29, 2023

@Jyyjy this is a great example. Very elegant and shows off a lot of functionality. Made some basic wording mods (to tie back to project better) and fixed some sp. THANK YOU!

@Jyyjy Jyyjy deleted the attribute_example branch February 7, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Instructional Material and Reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants