Repository navigation
Conversation
Contributor
|
@mcc0nnell please resolve the conflict |
mcc0nnell
force-pushed
the
fix/idempotency-key-storage-width
branch
from
October 5, 2026 12:40
cf26b37 to
df563d9
Compare
Author
|
@IOhacker Conflict is resolved on the current signed head df563d9, and GitHub now reports the PR as mergeable. The resolution preserves upstream migrations 0254/0255 and renumbers this PR's idempotency-key migration to 0256; the JPA mapping remains length = 255. The new Fineract CI, PR Compliance, and Signed Commits Check runs are all blocked at GitHub's fork-workflow action_required approval gate with no jobs started. Could you please approve and run the workflows? |
Contributor
|
@mcc0nnell Please make sure your commits are GPG signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Fineract currently accepts the configured idempotency header without applying a length constraint before command processing. The legacy
m_portfolio_command_source.idempotency_keycolumn and its JPA mapping are limited to 50 characters, while the newer JDBC command store usesVARCHAR(255).This change keeps the two command-storage paths consistent by:
m_portfolio_command_source.idempotency_keyfrom 50 to 255 characters via a new Liquibase migrationCommandSourceJPA mapping to matchThis is intentionally separate from #6231, which is hardening idempotency semantics for the newer command-processing path. This patch only removes a storage-width inconsistency in the legacy path.