-
Notifications
You must be signed in to change notification settings - Fork 2.1k
FINERACT-2386: Journal entry aggregation capabilities #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c940a7a
to
4dc8559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, couple of comments + let's remove the low quality javadoc/comments from the code.
...ract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobConfiguration.java
Outdated
Show resolved
Hide resolved
* Configuration for Journal entry aggregation job | ||
*/ | ||
@Configuration | ||
@EnableBatchIntegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an app-wide setting, shouldn't be here.
...ract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobConfiguration.java
Outdated
Show resolved
Hide resolved
...ract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobConfiguration.java
Outdated
Show resolved
Hide resolved
...he/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobReader.java
Outdated
Show resolved
Hide resolved
...he/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobReader.java
Outdated
Show resolved
Hide resolved
...he/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobReader.java
Show resolved
Hide resolved
...he/fineract/infrastructure/jobs/service/aggregationjob/JournalEntryAggregationJobWriter.java
Outdated
Show resolved
Hide resolved
4dc8559
to
5410da1
Compare
@galovics Thank you for your feedback! Kindly asking you to take a look on it! |
5410da1
to
e83257e
Compare
e83257e
to
2bd8d14
Compare
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.