WIP: FINERACT-2324: remove fetch all transactions from cob jobs #5019
+942
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budaidev
force-pushed
the
FINERACT-2324/remove-fetch-all-transactions-from-cob-jobs
branch
8 times, most recently
from
27c3c3a to
0554d40
Compare
budaidev
force-pushed
the
FINERACT-2324/remove-fetch-all-transactions-from-cob-jobs
branch
2 times, most recently
from
fe45358 to
23a45ae
Compare
…Fix refund validator
budaidev
force-pushed
the
FINERACT-2324/remove-fetch-all-transactions-from-cob-jobs
branch
5 times, most recently
from
9d31351 to
63aa883
Compare
adamsaghy
reviewed
Sep 29, 2025
|
|
||
| // Create REPLAYED relation for user-initiated transactions (those with external IDs) | ||
| // This distinguishes legitimate business operations from internal processing artifacts | ||
| if (originalExternalId != null) { |
There was a problem hiding this comment.
external id has not much to do whether it is business operation or internal processing... not necessarily enabled external id for loan transactions...
adamsaghy
reviewed
Sep 29, 2025
| return true; | ||
| } | ||
|
|
||
| // For REPLAYED relations, include only those that are part of legitimate business operations |
There was a problem hiding this comment.
why do we need this? i am not fully understand the reasoning behind. Having external id or not has nothing to do with reverse-replay scenarios...
adamsaghy
reviewed
Sep 29, 2025
| loanAccountTransfersService.updateLoanTransaction(oldTransaction.getId(), newTransaction); | ||
| // Create reversal journal entries for old transaction if it exists (reverse-replay scenario) | ||
| loanJournalEntryPoster.postJournalEntriesForLoanTransaction(oldTransaction, false, false); | ||
| // Only create reversal journal entries for old transaction if the old transaction is not already |
There was a problem hiding this comment.
Are you sure? I dont recall any reported bug whether something was incorrectly or double accounted.
budaidev
force-pushed
the
FINERACT-2324/remove-fetch-all-transactions-from-cob-jobs
branch
from
63aa883 to
db9b2d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.