Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @NonNull annotations to dependencies in NotificationApiResource #4306

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

a7med3del1973
Copy link
Contributor

@a7med3del1973 a7med3del1973 commented Feb 6, 2025

Description

  • Added NonNull annotation to the dependencies in the NotificationApiResource class it doesn't directly affect the behavior of the code (Note : I'm preparing myself for gsoc so i'm waiting for feedback. The NonNull annotation is a compile-time check provided by Lombok. It ensures that the dependencies injected via the constructor are not null only enforces null safety at runtime. )

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy
Copy link
Contributor

@a7med3del1973 Dear Ahmed,

To be honest with you i am not really see any additional value of the null check on the injected fields here...

@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Feb 6, 2025

@adamsaghy
Got it !
I will try to shift my attention to solving high-priority bugs instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants