[enhancement] Support disabling CSV quote parsing by NONE_QUOTE #846feat:#847
Open
huangzengtian wants to merge 1 commit intoapache:mainfrom
Open
[enhancement] Support disabling CSV quote parsing by NONE_QUOTE #846feat:#847huangzengtian wants to merge 1 commit intoapache:mainfrom
huangzengtian wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #846
What's changed?
Rationale
Currently, the quote configuration in CsvReaderBuilder does not support an explicit "disabled" state. Setting it to null is ambiguous (could mean "use default" or "disable"). This PR introduces a special constant to explicitly disable quote parsing, which is essential for processing raw TSV/CSV data (like Amazon reports) where quotes are part of the literal content and should not be escaped or wrapped.
Design Decisions
Introduced CsvConstant.NONE_QUOTE ('\0'): Followed the industrial practice of Apache Commons CSV (where withQuote(null) disables quoting).
Enhanced Javadoc: Added clear instructions in CsvReaderBuilder#quote to guide users on how to use NONE_QUOTE.
Checklist