feat: support for reading shared formulas in xlsx files#581
Closed
delei wants to merge 5 commits intoapache:mainfrom
delei:issue-571
Closed
feat: support for reading shared formulas in xlsx files#581delei wants to merge 5 commits intoapache:mainfrom delei:issue-571
delei wants to merge 5 commits intoapache:mainfrom
delei:issue-571
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reading shared formulas in XLSX files, which allows for more efficient storage and processing of repeated formulas across multiple cells.
- Added shared formula handling logic to track and resolve formula references
- Introduced new XML attributes for identifying and indexing shared formulas
- Enhanced XlsxReadSheetHolder to store shared formula mappings
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CellFormulaTagHandler.java | Main implementation for parsing and resolving shared formulas from XML |
| XlsxReadSheetHolder.java | Added storage for shared formula index and mapping |
| ExcelXmlConstants.java | Added constants for shared formula XML attributes |
| CellDataDataTest.java | Added test case for reading formulas from XLSX files |
| CellDataReadData.java | Removed empty comment block |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fastexcel/src/main/java/cn/idev/excel/analysis/v07/handlers/CellFormulaTagHandler.java
Outdated
Show resolved
Hide resolved
fastexcel/src/main/java/cn/idev/excel/analysis/v07/handlers/CellFormulaTagHandler.java
Outdated
Show resolved
Hide resolved
Member
|
celldata_formula_sum.xlsx |
|
工作簿1.xlsx this file seems like dismatch |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose of the pull request
Close #571
What's changed?
Checklist