[Bug] 使用table的relativeHeadRowIndex()设置写入行偏移量时效果不对

[32154678925]

Search before asking

• I searched in the issues and found nothing similar.

Fesod version

1.3.0

JDK version

Microsoft OpenJDK 17.0.17

Operating system

Windows11 专业版 24H2

Steps To Reproduce

Current Behavior

实际上第一个对象的数据头在第6行，数据从第12行开始

Expected Behavior

预期第一个对象的数据头在第6行，数据从第7行开始

Anything else?

在添加数据时，会初始化当前table

在初始话当前table的时候会写入设置的head，并且从指定的偏移量开始，我这里是5，所以从第6行开始，这是对的

紧接着在添加数据的时候，获取到了添加head之后的行数，7，这是对的，但是再一次获取了偏移量，导致了这个错误

Are you willing to submit a PR?

• I'm willing to submit a PR!

[32154678925]

另外，如果不写入head，那么relativeHeadRowIndex()设置的偏移值则完全没用，
int newRowIndex = writeSheetHolder.getNewRowIndexAndStartDoWrite(); if (writeSheetHolder.isNew() && !writeSheetHolder.getExcelWriteHeadProperty().hasHead()) { newRowIndex += writeContext.currentWriteHolder().relativeHeadRowIndex(); }
上述代码中的writeSheetHolder.isNew()和!writeSheetHolder.getExcelWriteHeadProperty().hasHead()导致了这个问题，是不是可以使用currentWriteHolder，并在相应的初始化过程例如currentSheet或currentTable中正确初始化相关内容，如head，并设置isNew为false

[bengbengbalabalabeng]

Based on my understanding, it should only be necessary to change the writeSheetHolder in the if condition to currentWriteHolder, while keeping the rest of the logic unchanged.

After changed demo:

View full code

ExcelWriterBuilder write = FastExcelFactory.write(OUTPUT);
ExcelWriterSheetBuilder sheetBuilder = write.sheet(0, "测试");
WriteSheet sheet = sheetBuilder.build();

WriteSheet collect = sheetBuilder
        .relativeHeadRowIndex(1)
        .head(ExcelModel.class)
        .build();

WriteTable tableA = sheetBuilder.table(0)
        .relativeHeadRowIndex(3)
        .head(TableA.class)
        .build();

WriteTable tableB = sheetBuilder.table(1)
        .relativeHeadRowIndex(6)
        .head(TableB.class)
        .build();

try (ExcelWriter writer = write.build()) {
    for (int i = 1; i <= 1; i++) {
        List<ExcelModel> dataList = new ArrayList<>();
        for (int j = 0; j < 10; j++) {
            ExcelModel result = new ExcelModel();
            result.setSchool("湘北高中");
            result.setClazz("一班");
            result.setNo("00" + j);
            dataList.add(result);
        }
        writer.write(dataList, collect);
    }

    for (int i = 1; i <= 1; i++) {
        List<TableA> dataList = new ArrayList<>();
        for (int j = 0; j < 10; j++) {
            TableA result = new TableA();
            result.setName("张三");
            result.setAge(18);
            result.setDate(new Date());
            dataList.add(result);
        }
        writer.write(dataList, sheet, tableA);
    }
    for (int i = 1; i <= 1; i++) {
        List<TableB> dataList = new ArrayList<>();
        for (int j = 0; j < 10; j++) {
            TableB result = new TableB();
            result.setHeight(180);
            result.setAddress("北京");
            result.setPhone("12345678901");
            dataList.add(result);
        }
        writer.write(dataList, sheet, tableB);
    }

    writer.finish();
}

Output:

[32154678925]

Based on my understanding, it should only be necessary to change the writeSheetHolder in the if condition to currentWriteHolder, while keeping the rest of the logic unchanged.

After changed demo:

View full code
ExcelWriterBuilder write = FastExcelFactory.write(OUTPUT);
ExcelWriterSheetBuilder sheetBuilder = write.sheet(0, "测试");
WriteSheet sheet = sheetBuilder.build();

WriteSheet collect = sheetBuilder
.relativeHeadRowIndex(1)
.head(ExcelModel.class)
.build();

WriteTable tableA = sheetBuilder.table(0)
.relativeHeadRowIndex(3)
.head(TableA.class)
.build();

WriteTable tableB = sheetBuilder.table(1)
.relativeHeadRowIndex(6)
.head(TableB.class)
.build();

try (ExcelWriter writer = write.build()) {
for (int i = 1; i <= 1; i++) {
List dataList = new ArrayList<>();
for (int j = 0; j < 10; j++) {
ExcelModel result = new ExcelModel();
result.setSchool("湘北高中");
result.setClazz("一班");
result.setNo("00" + j);
dataList.add(result);
}
writer.write(dataList, collect);
}

for (int i = 1; i <= 1; i++) {
    List<TableA> dataList = new ArrayList<>();
    for (int j = 0; j < 10; j++) {
        TableA result = new TableA();
        result.setName("张三");
        result.setAge(18);
        result.setDate(new Date());
        dataList.add(result);
    }
    writer.write(dataList, sheet, tableA);
}
for (int i = 1; i <= 1; i++) {
    List<TableB> dataList = new ArrayList<>();
    for (int j = 0; j < 10; j++) {
        TableB result = new TableB();
        result.setHeight(180);
        result.setAddress("北京");
        result.setPhone("12345678901");
        dataList.add(result);
    }
    writer.write(dataList, sheet, tableB);
}

writer.finish();

}
Output:

先在sheet写后在table写是正常的，请问这是标准操作流程么？只依靠table写是错误流程么

[bengbengbalabalabeng]

请问这是标准操作流程么？只依靠table写是错误流程么

My previous code example might not have been fully described, which caused some misunderstanding.
What I meant is that simply replacing writeSheetHolder with currentWriteHolder in the if condition allows all scenarios to work correctly — whether writing a single Table, a normal Sheet, or a combined write as shown in the example.
The code snippet above is an example of the combined write scenario.

我之前的代码示例可能没有描述完整，导致产生了一些误解。
我想表达的是：只需要把 if 判断中的 writeSheetHolder 替换为 currentWriteHolder，无论是单独写 Table、写普通 Sheet，还是像示例中这样组合写，都能正常处理。
上面的代码示例就是组合写的场景。

[32154678925]

我是新手，我想要推送一个提交来修正这个bug，我使用的是1.3.0版本，可是我观察到最新的版本结构发生了变化，我拉取最新的2.0.0-incubating-RC3，我发现项目会报错，ExcelWriteAddExecutor类需要依赖org.apache.fesod.shaded.cglib.beans.BeanMap，可org.apache.fesod里只有一个support，而且我不确定最新版是否有这个bug，我已经签署了ICLA，正在审核，请问接下来我需要做什么？

[bengbengbalabalabeng]

我是新手，我想要推送一个提交来修正这个bug，我使用的是1.3.0版本，可是我观察到最新的版本结构发生了变化，我拉取最新的2.0.0-incubating-RC3，我发现项目会报错，ExcelWriteAddExecutor类需要依赖org.apache.fesod.shaded.cglib.beans.BeanMap，可org.apache.fesod里只有一个support，而且我不确定最新版是否有这个bug，我已经签署了ICLA，正在审核，请问接下来我需要做什么？

You should be based on the main development branch.
For more details please refer to: https://fesod.apache.org/community/contribution/contribute-code/#branch-definition

你应该基于 main 分支处理。
更多细节请参考：https://fesod.apache.org/community/contribution/contribute-code/#branch-definition

[bengbengbalabalabeng]

我发现项目会报错，ExcelWriteAddExecutor类需要依赖org.apache.fesod.shaded.cglib.beans.BeanMap，可org.apache.fesod里只有一个support

In the local dev, you can try run the following command to compile

mvn clean install -DskipTests

在本地开发中，可以尝试运行以下命令进行编译

mvn clean install -DskipTests