Skip to content

[Docs] Add http request doc instruction #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2022
Merged

[Docs] Add http request doc instruction #922

merged 3 commits into from
Jun 17, 2022

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Jun 16, 2022 •
edited
Loading

Add http request doc instruction for using curl command.
close #925

@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #922 (630e8e1) into master (a34e69f) will not change coverage.
The diff coverage is n/a.

❗ Current head 630e8e1 differs from pull request most recent head ceb4559. Consider uploading reports for the commit ceb4559 to get more accurate results

@@           Coverage Diff            @@
##             master    #922   +/-   ##
========================================
  Coverage      8.57%   8.57%           
  Complexity      533     533           
========================================
  Files           353     353           
  Lines         22741   22741           
  Branches       2498    2498           
========================================
  Hits           1950    1950           
  Misses        20640   20640           
  Partials        151     151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34e69f...ceb4559. Read the comment docs.

@qqeasonchen
Copy link
Contributor

@xwm1992 I suggest you create an issue with it, and use curl instead of the postman in the doc.

ruanwenjun
ruanwenjun previously approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
NIT: Can we provide the postman template for example.

@xwm1992
Copy link
Contributor Author

xwm1992 commented Jun 17, 2022

@xwm1992 I suggest you create an issue with it, and use curl instead of the postman in the doc.

done

qqeasonchen
qqeasonchen approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit d7b318e into apache:master Jun 17, 2022
@ruanwenjun ruanwenjun added this to the 1.5.0 milestone Jun 25, 2022
xwm1992 added a commit that referenced this pull request Aug 4, 2022
@xwm1992
[Docs] Add http request doc instruction (#922)
b9903b1 
* add http request doc instruction

* update http request doc instruction

* update http request doc instruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqeasonchen qqeasonchen qqeasonchen approved these changes

@ruanwenjun ruanwenjun ruanwenjun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

[Doc] Add http request doc instruction
3 participants
@xwm1992 @qqeasonchen @ruanwenjun