[ISSUE #865] EM-Webhook: repair exception handling && send webhook CloudEvents #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eight-nines please create an issue first and associate it with this pr. |
eight-nines
changed the title
Yes, please have a look |
|
@eight-nines please pay attention to the CI check fail task |
githublaohu
reviewed
Jun 15, 2022
| try (final InputStream inputStream = WebHookController.class.getClassLoader().getResourceAsStream("eventmesh.properties")) { | ||
| properties = new Properties(); | ||
| properties.load(inputStream); | ||
| } |
There was a problem hiding this comment.
cloudEvent Producer 支持http，rocketmq等。具体是那种WebHookConfig 有配置，里面有cloudevent服务的地址，端口，topic
| .withType(eventType) | ||
| .withData(body) | ||
| .build(); | ||
| eventMeshHttpProducer.publish(event); |
|
I'll do my best |
added 2 commits
June 18, 2022 13:16
xwm1992
added a commit
that referenced
this pull request
Aug 4, 2022
[ISSUE #865] EM-Webhook: repair exception handling && send webhook CloudEvents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE #<865>.
Motivation
repair exception handling && send webhook CloudEvents