Skip to content

[ISSUE #4489] Migrate eventmesh-admin module #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

Pil0tXia
Copy link
Member

Fixes #4489.

Motivation

The /topicManage endpoint in the old admin module, which is not implemented and not used in the dashboard, has the same function as the /topic endpoint in runtime.admin. Therefore, it will be replaced by the new admin module.

Modifications

Replace eventmesh-admin module with the eventmesh-console module.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia marked this pull request as draft October 16, 2023 09:42
@Pil0tXia Pil0tXia marked this pull request as ready for review October 16, 2023 14:21
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4490 (d97b4e2) into master (093fb6b) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head d97b4e2 differs from pull request most recent head c047820. Consider uploading reports for the commit c047820 to get more accurate results

@@             Coverage Diff              @@
##             master    #4490      +/-   ##
============================================
- Coverage     15.59%   15.48%   -0.11%     
+ Complexity     1476     1453      -23     
============================================
  Files           698      691       -7     
  Lines         28205    28099     -106     
  Branches       2633     2626       -7     
============================================
- Hits           4398     4351      -47     
+ Misses        23360    23304      -56     
+ Partials        447      444       -3     
Files Coverage Δ
...ntime/admin/controller/ClientManageController.java 97.77% <ø> (-0.10%) ⬇️
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 1.53% <ø> (ø)
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.68% <0.00%> (ø)
...he/eventmesh/runtime/boot/HTTPThreadPoolGroup.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pandaapo pandaapo merged commit 53e36b5 into apache:master Oct 17, 2023
@Pil0tXia Pil0tXia deleted the pil0txia_feat_4489 branch January 4, 2024 05:06
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
* remove old module

* remove old module dependency and reference

* optimize webhook operationMode to lowercase

* rename software package

* rename project and builder

* optimize admin config and thread pool

* remove old usages in test class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Migrate eventmesh-admin module
3 participants