Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4374] Redesign registry module into meta storage #4418

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Aug 29, 2023

Fixes #4374 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4418 (9c49800) into master (fbbb81d) will not change coverage.
The diff coverage is 34.45%.

❗ Current head 9c49800 differs from pull request most recent head 1f85f13. Consider uploading reports for the commit 1f85f13 to get more accurate results

@@            Coverage Diff            @@
##             master    #4418   +/-   ##
=========================================
  Coverage     17.49%   17.49%           
  Complexity     1545     1545           
=========================================
  Files           665      665           
  Lines         26487    26487           
  Branches       2442     2442           
=========================================
  Hits           4635     4635           
  Misses        21400    21400           
  Partials        452      452           
Files Changed Coverage Δ
...ntmesh/registry/consul/config/ConsulTLSConfig.java 28.57% <ø> (ø)
...esh/registry/consul/service/HeatBeatScheduler.java 0.00% <ø> (ø)
...eventmesh/registry/etcd/constant/EtcdConstant.java 0.00% <ø> (ø)
...tmesh/registry/etcd/factory/EtcdClientWrapper.java 0.00% <ø> (ø)
...e/eventmesh/registry/etcd/factory/EtcdLeaseId.java 35.00% <ø> (ø)
...mesh/registry/etcd/factory/EtcdStreamObserver.java 0.00% <ø> (ø)
...tmesh/registry/etcd/service/EtcdCustomService.java 0.00% <0.00%> (ø)
...istry/nacos/config/NacosRegistryConfiguration.java 91.66% <ø> (ø)
...entmesh/registry/nacos/constant/NacosConstant.java 0.00% <ø> (ø)
...stry/zookeeper/config/ZKRegistryConfiguration.java 95.23% <ø> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Pil0tXia
Copy link
Member

The corresponding issue should be #4374 instead of #4347.

@xwm1992 xwm1992 changed the title [ISSUE #4347] Redesign registry module into meta storage [ISSUE #4374] Redesign registry module into meta storage Aug 30, 2023
@xwm1992 xwm1992 merged commit 5d390d3 into apache:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Redesign registry module into meta storage
4 participants