[ISSUE #3892] SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body #3893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3893 +/- ##
============================================
+ Coverage 14.24% 14.55% +0.31%
- Complexity 1320 1350 +30
============================================
Files 579 580 +1
Lines 28967 28811 -156
Branches 2802 2799 -3
============================================
+ Hits 4125 4194 +69
+ Misses 24450 24225 -225
Partials 392 392
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3893 +/- ##
============================================
+ Coverage 14.24% 14.55% +0.31%
- Complexity 1320 1350 +30
============================================
Files 579 580 +1
Lines 28967 28811 -156
Branches 2802 2799 -3
============================================
+ Hits 4125 4194 +69
+ Misses 24450 24225 -225
Partials 392 392 ☔ View full report in Codecov by Sentry. |
| */ | ||
| public abstract class BaseSendMsgRequestHeader extends Header { | ||
|
|
||
| //request code | ||
| private String code; |
There was a problem hiding this comment.
How about using the AbstractSendMsgRequestHeader naming, to match the naming of other classes?
| public void setCode(String code) { | ||
| this.code = code; | ||
| } | ||
|
|
||
| public String getLanguage() { | ||
| return language; | ||
| } | ||
|
|
||
| public void setLanguage(String language) { | ||
| this.language = language; | ||
| } |
There was a problem hiding this comment.
How about using the @Data annotation to save space on those getters and setters?
Pil0tXia
changed the title
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3892.
Motivation
See "Enhancement Request" in issue.
Modifications
See "Describe the solution you'd like" in issue.
Documentation