-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3874] Add a load balance strategy: source ip hash #3875
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
============================================
- Coverage 14.24% 14.01% -0.23%
+ Complexity 1320 1303 -17
============================================
Files 579 572 -7
Lines 28967 28891 -76
Branches 2802 2818 +16
============================================
- Hits 4125 4049 -76
- Misses 24450 24469 +19
+ Partials 392 373 -19
... and 142 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3875 +/- ##
============================================
- Coverage 14.24% 14.01% -0.23%
+ Complexity 1320 1303 -17
============================================
Files 579 572 -7
Lines 28967 28891 -76
Branches 2802 2818 +16
============================================
- Hits 4125 4049 -76
- Misses 24450 24469 +19
+ Partials 392 373 -19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please resolve conflicts.
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3874.
Motivation
Add a load balance strategy: source ip hash. Make the same client machine always arrive at the same server.
Modifications
Add a new LoadBalanceSelector for implementing source ip hash algorithm.
Add unit test for new LoadBalanceSelector.
Documentation