Skip to content

[ISSUE #1028] support Etcd Registry #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 3, 2022

Conversation

JellyBo
Copy link
Contributor

@JellyBo JellyBo commented Jul 18, 2022

Fixes ISSUE #1028 .

Modifications

Describe the modifications you've done.

Support Etcd registry implementation:
Interconnecting with Etcd v3.6.0

  • update grpc version from 1.15.0 to 1.17.1
  • add etcd registry support
  • how to use, add etcd registry properties, for example:
    eventMesh.registry.plugin.enabled=true
    eventMesh.registry.plugin.type=etcd
    eventMesh.registry.plugin.server-addr=127.0.0.1:2379

@JellyBo JellyBo force-pushed the registry-etcd-jelly branch from 2410f5f to ce7c8c6 Compare July 21, 2022 05:02
@xwm1992
Copy link
Contributor

xwm1992 commented Aug 2, 2022

@JellyBo Hi, please fixed the UT's error,thanks.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1029 (2e94c9a) into registry-etcd (24e5c19) will increase coverage by 1.54%.
The diff coverage is 27.90%.

@@                Coverage Diff                 @@
##             registry-etcd   #1029      +/-   ##
==================================================
+ Coverage             8.30%   9.85%   +1.54%     
- Complexity             528     626      +98     
==================================================
  Files                  362     368       +6     
  Lines                23118   23341     +223     
  Branches              2546    2569      +23     
==================================================
+ Hits                  1920    2300     +380     
+ Misses               21048   20827     -221     
- Partials               150     214      +64     
Impacted Files Coverage Δ
...mmon/protocol/grpc/protos/ConsumerServiceGrpc.java 0.00% <ø> (ø)
...mon/protocol/grpc/protos/HeartbeatServiceGrpc.java 0.00% <ø> (ø)
...mon/protocol/grpc/protos/PublisherServiceGrpc.java 0.00% <ø> (ø)
...eventmesh/registry/etcd/constant/EtcdConstant.java 0.00% <0.00%> (ø)
...mesh/registry/etcd/factory/EtcdStreamObserver.java 0.00% <0.00%> (ø)
...esh/registry/etcd/service/EtcdRegistryService.java 21.95% <21.95%> (ø)
...tmesh/registry/etcd/factory/EtcdClientWrapper.java 33.33% <33.33%> (ø)
...tmesh/registry/etcd/factory/EtcdClientFactory.java 38.00% <38.00%> (ø)
...e/eventmesh/registry/etcd/factory/EtcdLeaseId.java 50.00% <50.00%> (ø)
...e/eventmesh/common/config/CommonConfiguration.java 80.95% <0.00%> (-2.92%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 1002bdb into apache:registry-etcd Aug 3, 2022
xwm1992 added a commit that referenced this pull request Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants