[Question] Some questions in grpc feature

[xwm1992]

Search before asking

• I had searched in the issues and found no similar issues.

Question

Now that eventmesh support transfer message with http/tcp/grpc three ways, have some questions below:

• as we first design we have supported two protocols(cloudevents/eventmesh message)
• for http transfer method, we use the HttpCommand carry both protocols messages
• for tcp transfer method, we use the Package carry both protocols messages
• for grpc transfer method, we use the EventMeshMessage/BatchMessage carry both protocols messages

Now, for grpc transfer method, I just see convert the cloudevents to eventmesh message, like pic below. I just think this is a protocols conversion function, but if we treat this just as a message carrier, please don't name it as EventMeshMessage because this is a protocol.

@jinrongluo please take a look, thanks

[jinrongluo]

Hi @xwm1992 Thanks for your review.

GRPC protocol messaging model is different from TCP and HTTP. We have different message model for different Service/Operations:

• EventMeshMessage
• BatchMessage
• Subscription
• Heartbeat

Detail is in this protobuf file:

https://github.com/apache/incubator-eventmesh/blob/grpc/eventmesh-protocol-plugin/eventmesh-protocol-grpc/src/main/proto/eventmesh-client.proto

[jinrongluo]

Discussed with @xwm1992 offline. We agree to rename EventMeshMessage to SimpleMessage.

[jinrongluo]

hi @xwm1992 as per your suggestion. I rename the GRPC publish message to SimpleMessage.

Here is the commit - 802b010
f0d1b8a

The PR is here - #723

Thanks for review.

[xwm1992]

@jinrongluo Hi, I have some questions for the grpc structure of sdk module, for the Pub side, there batch\publish\request-reply three modes for publish; for the Sub side, I only find the async subcribe mode, how can I use the request-reply for grpc?

[vongosling]

I will close this issue, we could create a new issue to discuss the remaining issues for our new Grpc features. Codes still in grpc branch.