-
Notifications
You must be signed in to change notification settings - Fork 639
Closed
Labels
Description
Search before asking
- I had searched in the issues and found no similar issues.
Feature Request
- Deprecate
eventMesh.connector.plugin.type: EventMesh does not use this config to determine which connector to use. This config can easily confuse users. It is not referenced in implementation code either. - Deprecate
registerIntervalInMills,fetchRegistryAddrIntervalInMills: These two configs were placed seperatly from metaStorage plugins, however they are always (in Git history) misconfigured (missingpluginlevel) & not used since EventMesh initated.
eventmesh/eventmesh-runtime/conf/eventmesh.properties
Lines 63 to 64 in fe2bd7c
eventMesh.server.metaStorage.metaStorageIntervalInMills=10000 eventMesh.server.metaStorage.fetchMetaStorageAddrIntervalInMills=20000
eventmesh/eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java
Lines 70 to 74 in fe2bd7c
@ConfigField(field = "metaStorage.plugin.metaStorageIntervalInMills") private Integer eventMeshMetaStorageIntervalInMills = 10 * 1000; @ConfigField(field = "metaStorage.plugin.fetchMetaStorageAddrIntervalInMills") private Integer eventMeshFetchMetaStorageAddrInterval = 10 * 1000; - Deprecate
eventMesh.server.defibus.client.comsumeTimeoutInMinand 'defibus' related usages: These usages are commented and not used since EventMesh initated, and may output one line of null log.

- Place similar properties together and add a seperator.
- I found out that I forgot to unify
null != objectin [ISSUE #4808] Unify allnull == objectusage to standardobject == null#4809 when writting this PR (onlynull == objectusages unified), so this PR contains supplements of the previous one.
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct *