Skip to content

[Feature] Deprecate unused eventMesh.connector.plugin.type etc. properties #4838

Closed
@Pil0tXia

Description

@Pil0tXia

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

  • Deprecate eventMesh.connector.plugin.type: EventMesh does not use this config to determine which connector to use. This config can easily confuse users. It is not referenced in implementation code either.
  • Deprecate registerIntervalInMills, fetchRegistryAddrIntervalInMills: These two configs were placed seperatly from metaStorage plugins, however they are always (in Git history) misconfigured (missing plugin level) & not used since EventMesh initated.
    eventMesh.server.metaStorage.metaStorageIntervalInMills=10000
    eventMesh.server.metaStorage.fetchMetaStorageAddrIntervalInMills=20000

    @ConfigField(field = "metaStorage.plugin.metaStorageIntervalInMills")
    private Integer eventMeshMetaStorageIntervalInMills = 10 * 1000;
    @ConfigField(field = "metaStorage.plugin.fetchMetaStorageAddrIntervalInMills")
    private Integer eventMeshFetchMetaStorageAddrInterval = 10 * 1000;
  • Deprecate eventMesh.server.defibus.client.comsumeTimeoutInMin and 'defibus' related usages: These usages are commented and not used since EventMesh initated, and may output one line of null log.
    image
  • Place similar properties together and add a seperator.
  • I found out that I forgot to unify null != object in [ISSUE #4808] Unify all null == object usage to standard object == null #4809 when writting this PR (only null == object usages unified), so this PR contains supplements of the previous one.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions