Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/component/marker/MarkAreaView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,11 @@ function createList(
const data = seriesModel.getData();
const info = data.getDimensionInfo(
data.mapDimension(coordDim)
) || {};
);
// In map series data don't have lng and lat dimension. Fallback to same with coordSys
return extend(extend({}, info), {
// When using dataset with encode, dimension info might be incomplete/undefined
const baseInfo = info ? extend({}, info) : new SeriesDimensionDefine({ name: coordDim, type: 'float' });
return extend(baseInfo, {
name: coordDim,
// DON'T use ordinalMeta to parse and collect ordinal.
ordinalMeta: null
Expand Down
6 changes: 4 additions & 2 deletions src/component/marker/MarkLineView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,11 @@ function createList(coordSys: CoordinateSystem, seriesModel: SeriesModel, mlMode
coordDimsInfos = map(coordSys && coordSys.dimensions, function (coordDim) {
const info = seriesModel.getData().getDimensionInfo(
seriesModel.getData().mapDimension(coordDim)
) || {};
);
// In map series data don't have lng and lat dimension. Fallback to same with coordSys
return extend(extend({}, info), {
// When using dataset with encode, dimension info might be incomplete/undefined
const baseInfo = info ? extend({}, info) : new SeriesDimensionDefine({ name: coordDim, type: 'float' });
return extend(baseInfo, {
name: coordDim,
// DON'T use ordinalMeta to parse and collect ordinal.
ordinalMeta: null
Expand Down
6 changes: 4 additions & 2 deletions src/component/marker/MarkPointView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ function createData(
coordDimsInfos = map(coordSys && coordSys.dimensions, function (coordDim) {
const info = seriesModel.getData().getDimensionInfo(
seriesModel.getData().mapDimension(coordDim)
) || {};
);
// In map series data don't have lng and lat dimension. Fallback to same with coordSys
return extend(extend({}, info), {
// When using dataset with encode, dimension info might be incomplete/undefined
const baseInfo = info ? extend({}, info) : new SeriesDimensionDefine({ name: coordDim, type: 'float' });
return extend(baseInfo, {
name: coordDim,
// DON'T use ordinalMeta to parse and collect ordinal.
ordinalMeta: null
Expand Down
223 changes: 223 additions & 0 deletions test/markLine-dataset-encode-fix.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading