Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): fix background animation when real time sort #18965

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/chart/bar/BarView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,18 @@ class BarView extends ChartView {
}
const bgLayout = getLayout[coord.type](data, newIndex);
const shape = createBackgroundShape(isHorizontalOrRadial, bgLayout, coord);
updateProps<RectProps | SectorProps>(bgEl, { shape }, animationModel, newIndex);

if (realtimeSortCfg) {
updateProps<RectProps | SectorProps>(
bgEl,
{ shape },
animationModel ? realtimeSortCfg.baseAxis.model : null,
newIndex
);
}
else {
updateProps<RectProps | SectorProps>(bgEl, { shape }, animationModel, newIndex);
}
}

let el = oldData.getItemGraphicEl(oldIndex) as BarPossiblePath;
Expand All @@ -361,6 +372,11 @@ class BarView extends ChartView {
isClipped = clip[coord.type](coordSysClipArea, layout);
if (isClipped) {
group.remove(el);

bgEls[newIndex]?.hide();
}
else {
bgEls[newIndex]?.show();
}
}

Expand Down
104 changes: 104 additions & 0 deletions test/bar-race-bg.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/runTest/actions/__meta__.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/runTest/actions/bar-race-bg.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.